[Patches] [ python-Patches-1577756 ] whitespace in `svnversion .`

[SourceForge.net]

Patches item #1577756, was opened at 2006-10-15 19:33
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1577756&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.5
>Status: Closed
>Resolution: Fixed
Priority: 2
Private: No
Submitted By: Daniel Stränger (schmaller)
>Assigned to: Georg Brandl (gbrandl)
Summary: whitespace in `svnversion .`

Initial Comment:
gcc (version 3.4.4) fails to compile
Modules/getbuildinfo.c,
since it works as documented and cuts the definition of
SVNVERSION at the first newline and so there is an
unbalanced double quote.

citation of the gcc manpage:
-D name=definition
  Predefine name as a macro, with definition definition.
  The contents of definition are tokenized and processed
  as if they appeared during translation phase three in
  a #define directive.  In particular, the definition
  will be truncated by embedded newline characters.


----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2006-12-08 20:47

Message:
Logged In: YES 
user_id=849994
Originator: NO

German output shouldn't have happened. It turns out that LANG=C isn't the
correct env var to force English output, now using LC_ALL=C in rev. 52970,
52971 (2.5).

----------------------------------------------------------------------

Comment By: Daniel Stränger (schmaller)
Date: 2006-12-07 23:59

Message:
Logged In: YES 
user_id=922469
Originator: YES

Now I've found the error (and the solution).
The culprit is the german version of svnversion: it returns the string
"exportiert ".
Notice the trailing space character.
This leads to the following expansion for #> gcc
-DSVNVERSION=\"`svnversion -n .`\" ...
    gcc -DSVNVERSION=\"exportiert \" ...
    and so SVNVERSION gets the value: <"exportiert>.
To solve this problem, the value of the macro SVNVERSION must again be
enclosed by double-quotes,
as you can see in the patch file.

Best regards,
Daniel
File Added: svnversion_whitespace.patch

----------------------------------------------------------------------

Comment By: Daniel Stränger (schmaller)
Date: 2006-10-15 21:12

Message:
Logged In: YES 
user_id=922469

The patch don't fix it and i think it's not a problem of Python.
I apologize for spamming the patch system.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1577756&group_id=5470