[Patches] [ python-Patches-1615701 ] Creating dicts for dict subclasses

SourceForge.net noreply at sourceforge.net
Tue Dec 19 18:50:57 CET 2006


Patches item #1615701, was opened at 2006-12-14 08:08
Message generated for change (Comment added) made by jimjjewett
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1615701&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: Python 2.6
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Walter Dörwald (doerwalter)
Assigned to: Nobody/Anonymous (nobody)
Summary: Creating dicts for dict subclasses

Initial Comment:
This patch changes dictobject.c so that creating dicts from mapping like objects only uses the internal dict functions if the argument is a *real* dict, not a subclass. This means that overwritten keys() and __getitem__() methods are now honored. In addition to that the fallback implementation now tries iterkeys() before trying keys(). It also adds a PyMapping_IterKeys() macro.

----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2006-12-19 12:50

Message:
Logged In: YES 
user_id=764593
Originator: NO

Why are you using iterkeys instead of iteritems?

It seems like if they've filled out the interface enough to have iterkeys,
they've probably filled it out all the way, and you do need the value as
soon as you get the key.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1615701&group_id=5470


More information about the Patches mailing list