[Patches] [ python-Patches-1045783 ] Remove unncessary NLST from ftp transfers

SourceForge.net noreply at sourceforge.net
Fri Dec 22 20:24:46 CET 2006


Patches item #1045783, was opened at 2004-10-12 19:05
Message generated for change (Comment added) made by akuchling
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1045783&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Chris Cogdon (chriscog)
>Assigned to: A.M. Kuchling (akuchling)
Summary: Remove unncessary NLST from ftp transfers

Initial Comment:
Using urllib (or urllib2) to open FTP URLs will attempt
a 'nlst' (directory listing) before retrieving the
file. Some FTP servers block directory listings, but
allow 'getting' files just fine.

Having urllib do a NLST before retriving files is
totally unnecessary, and will fail given the FTP server
mentioned above. If a file is not 'gettable', which is
what the probable intention of NLST is, it will fail in
the retrieve process.

This patch removes the NLST from urllib. As a bonus,
this makes FTP transfers faster.

----------------------------------------------------------------------

>Comment By: A.M. Kuchling (akuchling)
Date: 2006-12-22 14:24

Message:
Logged In: YES 
user_id=11375
Originator: NO

This fix seems to have been applied in rev. 45819.

----------------------------------------------------------------------

Comment By: John J Lee (jjlee)
Date: 2005-05-19 16:49

Message:
Logged In: YES 
user_id=261020

Looks reasonable to me.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1045783&group_id=5470


More information about the Patches mailing list