[Patches] [ python-Patches-1504073 ] Patch for 1496501 tarfile opener order

SourceForge.net noreply at sourceforge.net
Wed Dec 27 11:38:19 CET 2006


Patches item #1504073, was opened at 2006-06-10 19:45
Message generated for change (Comment added) made by gustaebel
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1504073&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Jack Diederich (jackdied)
Assigned to: Lars Gustäbel (gustaebel)
Summary: Patch for 1496501 tarfile opener order

Initial Comment:
when passing a fileobj into tarfile.open() without
specifying the type open() will try openers in their
dict key order from TarFile.OPEN_METH.  This can fail
if the order changes.

This patch adds a tell() and seek() on failure of
openers.  fileobjs must already support these methods
to work so this makes no new requirements.

OpenOrderTest uses a dict-alike with shuffled keys to
try and provoke the wrong orders for openers.

Let me know if it looks good and I'll check it in.


----------------------------------------------------------------------

>Comment By: Lars Gustäbel (gustaebel)
Date: 2006-12-27 11:38

Message:
Logged In: YES 
user_id=642936
Originator: NO

Made the testcase simpler and checked it in as rev. 53161 and rev. 53162
(2.5).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1504073&group_id=5470


More information about the Patches mailing list