[Patches] [ python-Patches-1514737 ] proposal for a new circle method

[SourceForge.net]

Patches item #1514737, was opened at 2006-06-30 00:36
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1514737&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.5
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Lingl (gregorlingl)
Assigned to: Martin v. Löwis (loewis)
Summary: proposal for a new circle method

Initial Comment:
The attached file contains the proposal for 

(1) a new circle method (here called circle2)
(2) a new circle function (also called circle2)

Moreover it contains a testscript showing the
respective3 filling behaviour.

Visually they behave differently and it may well
be a point of discussion if this replacement
schould be made.

circle2 has correct filling behaviour and doesn't
show the strange 'not drawing feature' after a
radians() call.

All the other problems with radians()/degrees()
remain. (see #1514685)



----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-07-03 12:06

Message:
Logged In: YES 
user_id=21627

Thanks for the patch. Committed as r47209.

----------------------------------------------------------------------

Comment By: Lingl (gregorlingl)
Date: 2006-06-30 21:23

Message:
Logged In: YES 
user_id=1547199

A misinterpretation:
I think it *should* become the circle method. (It were a 
weird idea to introduce a circle2 method anyway). I only
named it circle2 for now and test purposes in order to 
compare the behaviours of the two. If you are content
with the patch, replace circle by circle2 'as circle' - if
not leave circle2 out and let everything as is. Imho the 
the points to think about are:
(i) is the polygon approximation ok? I think, my testscript
gives a positive answer: the polygons are visually nearly
indistiguishable from the canvas circle items. (Moreover I
tested it with radiuses in the range from 1 to 200
successfully) 
(ii)that the new method relies on the forward method and
thus circles are drawn much slower. For me this is quite ok. 


----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-06-30 18:44

Message:
Logged In: YES 
user_id=21627

New methods are not acceptable for Python 2.5 at this point.

Can you think of a reason why this should *not* become the
circle method? I understand that this fixes a bug, right?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1514737&group_id=5470