[Patches] [ python-Patches-780595 ] Fix zip file header format in zipfile.py

SourceForge.net noreply at sourceforge.net
Sun Jul 30 15:39:43 CEST 2006


Patches item #780595, was opened at 2003-07-30 23:58
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=780595&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: None
>Status: Closed
Resolution: Fixed
Priority: 5
Submitted By: John M. Baughman (scuzball1)
Assigned to: Greg Ward (gward)
Summary: Fix zip file header format in zipfile.py

Initial Comment:
The zip file header unpack format uses signed longs for 
those values. For the readfile function to work with very 
large files (2GB+ in my case) it needs to use unsigned 
longs. In the case of these files, the readfile code would 
break with a memory error when trying to buffer 
backwards in memory since the value is converted to a 
signed long producing a negative value.

This patch converts the header unpack format to use 
unsigned longs.

-John M. Baughman


----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2006-07-30 13:39

Message:
Logged In: YES 
user_id=849994

Something similar has been done in rev. 36413.

----------------------------------------------------------------------

Comment By: John M. Baughman (scuzball1)
Date: 2003-07-31 15:44

Message:
Logged In: YES 
user_id=834241

My bad, this patch is for zipfile.py.

Got in a slight hurry last night and didn't complete the 
description well enough.

-John M. Baughman

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=780595&group_id=5470


More information about the Patches mailing list