[Patches] [ python-Patches-1452332 ] Minimalist fix for bug 1441408

[SourceForge.net]

Patches item #1452332, was opened at 2006-03-17 23:41
Message generated for change (Comment added) made by ncoghlan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1452332&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Nick Coghlan (ncoghlan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Minimalist fix for bug 1441408

Initial Comment:
Address bug 1446847 without modifying the AST - simply
explicitly set the slice step to None when a second
colon is present but no step expression is provided.

----------------------------------------------------------------------

>Comment By: Nick Coghlan (ncoghlan)
Date: 2006-03-18 04:00

Message:
Logged In: YES 
user_id=1038590

It does (confirmed by comparing dis.dis() output from my
patched build against Python 2.4).

This makes sense, since the generation of the implicit None
step is inside the "sliceop" guard, so its only executed
when the second colon is present.

Checked in as rev 43121.

----------------------------------------------------------------------

Comment By: Grant Olson (logistix)
Date: 2006-03-18 00:29

Message:
Logged In: YES 
user_id=699438

Does this generate the right bytecode if you're not using
extended notation (a[:])?  If so, it's better than my patch.

----------------------------------------------------------------------

Comment By: Nick Coghlan (ncoghlan)
Date: 2006-03-17 23:44

Message:
Logged In: YES 
user_id=1038590

The identifier in the description is for the proposed patch
that modifies the AST - title has been fixed to refer to
actual bug report (1441408)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1452332&group_id=5470