[Patches] [ python-Patches-1229511 ] Zipfile fix create_system information

[SourceForge.net]

Patches item #1229511, was opened at 2005-06-29 07:47
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1229511&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
Resolution: None
Priority: 5
Submitted By: Hendrik Muhs (hendriktt)
Assigned to: Nobody/Anonymous (nobody)
Summary: Zipfile fix create_system information

Initial Comment:
this patches corrects the create_system value for
created zipfiles with the zipfile module, which is
platform dependent (better: filesystem dependent). 
It fixes the following bug: if a zipfile is created
with Python on Unix and the files have executable flags
the file rights are correctly saved into the zipfile.
But when extracting the file with unzip (from Info-zip)
the filerights (executable flags) are not reassigned
correctly. This is due to the wrong create_system flag.

The patch is not the 100% correct way to do it, but it
is better as the situation now (completly ignore the
system and always set create_system to 0).

The right way to fix this would be to set the
create_system flag dependent on the platform and the
filesystem but I do not know how to do this.

----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2006-03-17 19:35

Message:
Logged In: YES 
user_id=849994

Waiting for input from OP.

----------------------------------------------------------------------

Comment By: Ronald Oussoren (ronaldoussoren)
Date: 2006-03-07 12:35

Message:
Logged In: YES 
user_id=580910

Could you check if the trunk is acceptable to you, and if so close this patch?

Patch 1412872 also sets create_system to another value on unix systems and 
was applied at 05 feb 2006.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1229511&group_id=5470