[Patches] [ python-Patches-1309579 ] A wait4() implementation

[SourceForge.net]

Patches item #1309579, was opened at 2005-09-30 08:32
Message generated for change (Comment added) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1309579&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Modules
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Submitted By: chads (cjschr)
>Assigned to: Neal Norwitz (nnorwitz)
Summary: A wait4() implementation

Initial Comment:
Implementation of a BSD-style wait4() function, which
is similar to waitpid, but it also returns resource usage
information about the child process.

wait4(pid, options) -> (pid, status, rusage)

Chad

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2006-03-18 14:18

Message:
Logged In: YES 
user_id=33168

I think I recall spotting the docs after your comment.  I
plan to get this in before alpha1.

----------------------------------------------------------------------

Comment By: chads (cjschr)
Date: 2006-01-19 05:47

Message:
Logged In: YES 
user_id=1093928

Neil

Check the diff.  Doc updates are already there.

Thanks.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2006-01-18 22:58

Message:
Logged In: YES 
user_id=33168

I looked over the patch.  It looks pretty good.  Can your
provide doc too?  If you can't do latex, just text will do
and I'll convert.

Doc/lib/libos.tex

----------------------------------------------------------------------

Comment By: chads (cjschr)
Date: 2006-01-17 14:52

Message:
Logged In: YES 
user_id=1093928

Took a different approach with implementation.
Also includes wait3 implementation.

LMK how it looks.  Thanks.
Chad

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2005-10-02 14:56

Message:
Logged In: YES 
user_id=33168

Comments from author received in mail:

It is a duplicate of my original post, but it was diff'ed
against the latest CVS tree.

The usage example is for those who haven't had experience with
wait4 before, hence the name.  It's an FYI, nothing more.
I'll also update the documentation accordingly.



----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2005-09-30 20:16

Message:
Logged In: YES 
user_id=33168

Chad, I'm starting to look at this now, but it seems to be a
duplicate of your original patch # 1000267.  Can this be
closed as a duplicate?  I don't know if the attachments are
the same.  

It would be easier to have all the changes in a single file.
 Since you are adding a new file, you will need to use -N
option to cvs diff.  Something like this:  cvs diff -Nu ...
(you can list the specific files that changed if necessary).

>From what I looked at so far, there were a couple of things
I didn't like.  Though it looks like you addressed many
(perhaps all) of the previous comments.

I don't like the code in resourcemodule.h.  I would prefer a
public API in resourcemodule that posixmodule can call.  If
you think that no other modules outside python should call
this, you can prefix the name with _, ie
_PyResourceModule_...().

There are some un-prefixed names in resourcemodule.h.  I
think these may all go away if you move the code into the .c
file.  I would prefer to not have resourcemodule_h_author &
resourcemodule_h_rcsid.  The comment with your name and
email is fine.

I didn't look at the test or usage example.  What should be
done with the usage example?  In the doc, could you remove
the ", ?" for availability.  We can leave it as Unix for
now.  If we find out definitive info about other platforms
(Windows, Mac), we can add that later.  Please add a
\versionadded{2.5} at the end of the new doc (before the end).

That's all my comments.  This looks close to being ready.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1309579&group_id=5470