[Patches] [ python-Patches-1449471 ] Splitting CJK codecs from pythoncore dll

[SourceForge.net]

Patches item #1449471, was opened at 2006-03-14 19:18
Message generated for change (Comment added) made by perky
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1449471&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.5
Status: Open
Resolution: Accepted
Priority: 5
Submitted By: Hye-Shik Chang (perky)
Assigned to: Hye-Shik Chang (perky)
Summary: Splitting CJK codecs from pythoncore dll

Initial Comment:
As many of western language natives have requested it,
this patch splits CJK codecs from pythoncore dll. 
python25.dll shrinks from 2024KB to 1364KB by this. 
Even some of CJK users would take some advantages for
domestic py2exe-ed releases.

----------------------------------------------------------------------

>Comment By: Hye-Shik Chang (perky)
Date: 2006-03-19 22:22

Message:
Logged In: YES 
user_id=55188

Aah.  Then, how about to use a way how the PuTTY project does?
They maintain a relatively simple perl script to generate
various types of build files including MSVC6 dsw, MSVC7.1
sln, Dev-Cpp project, MinGW Makefile, MS nmake Makefile and
Borland C++ project file at a time.  If we make a simliar
thing, keeping PC/VC6 up-to-date would become a bit easy.

I'll try it in my spare time before the first alpha of 2.5.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-03-19 20:56

Message:
Logged In: YES 
user_id=21627

The main issue is maintainability. Everytime a module is
added, a project file needs to be created, which is more
tedious than adding a few lines to setup.py (although one
also has to remember editing Modules/Setup.dist); in
addition, Tools/msi/msi.py needs to be edited.

Everytime a "global" change is made to the compilation
options of Python (e.g. adding AMD64 configurations), it
needs to be applied to all project files individually.

----------------------------------------------------------------------

Comment By: Hye-Shik Chang (perky)
Date: 2006-03-19 19:20

Message:
Logged In: YES 
user_id=55188

Yes.  I agree about the arbitrariness where to modules go.
I thought that some dll size was concerned looking
"unicodedata" module case; which is only 396KB.  It would be
clearer if we use same scheme for Windows distribution as
specified in Modules/Setup.dist. (what drawbacks are
expected then?)

Thank you for the review!

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-03-19 19:00

Message:
Logged In: YES 
user_id=21627

I must say that I find this splitting arbitrary. Why are
these modules moved out of pythonxy.dll, when, say,
multibytecodec, mmap, parser, xxsubtype, sha512 stay. I
really wish there was some policy guiding this.

That said, as the author of the code, it is certainly your
decision to make that split that way. So please go ahead and
apply that patch.

Please also add the new modules to Tool/msi/msi.py.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1449471&group_id=5470