[Patches] [ python-Patches-1458476 ] Improved PySet C API
SourceForge.net
noreply at sourceforge.net
Sun Mar 26 00:56:27 CET 2006
Patches item #1458476, was opened at 2006-03-25 17:48
Message generated for change (Comment added) made by rhettinger
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1458476&group_id=5470
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Submitted By: Barry A. Warsaw (bwarsaw)
>Assigned to: Guido van Rossum (gvanrossum)
Summary: Improved PySet C API
Initial Comment:
This patch adds PySet_Next(), PySet_Update(), and
PySet_Clear(), three very useful API calls when you're
dealing with concrete PySet objects.
Patch includes tests and documentation.
----------------------------------------------------------------------
>Comment By: Raymond Hettinger (rhettinger)
Date: 2006-03-25 18:56
Message:
Logged In: YES
user_id=80475
Guido, please reject this patch.
I laid-out my reasoning in these two posts:
http://mail.python.org/pipermail/python-dev/2006-
March/062652.html
http://mail.python.org/pipermail/python-dev/2006-
March/062737.html
In particular, I've found PySet_Next() to be disasterously
error-prone (and have had to fix several hard-to-find bugs
directly attributable this function). There was some need
for it in the PyDict API because it fetched key and value
pointers at the same time and allowed direct modification
of values. This of course does not apply to sets which do
not have a value field.
The PySet_Clear() function should be PyObject_Clear() like
other functions that have tp_slots. There is no more of a
case for this function than there would be for PySet_Repr,
PySet_Len, PySet_IsTrue, or PySet_Print.
The PySet_Update() function gets in the way of my future
development plans for this module.
None of these functions are necessary. They simply
reflect Barry's programming style and views on having fat,
overly-concrete APIs.
This patch is against my wishes for the module. As the
module author and principal maintainer, if I still have a
say in the module's development, I strongly prefer
rejection of this patch.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1458476&group_id=5470
More information about the Patches
mailing list