[Patches] [ python-Patches-1576954 ] Fix VC6 build, remove redundant files for VC7 build

[SourceForge.net]

Patches item #1576954, was opened at 2006-10-14 02:09
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1576954&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build
Group: Python 2.6
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Larry Hastings (lhastings)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix VC6 build, remove redundant files for VC7 build

Initial Comment:
The VC6 build for pythoncore (PC/VC6/pythoncore.dsp) was shipped broken in 2.5.  This fixes it, as well as updating it for Python 2.6, and you can now once again produce python.exe (and python_d.exe) using VC6.  (This fix could easily be backported to 2.5; I would be happy to submit that separately.)

The VC7 build for pythoncore (PCBuild/pythoncore.vcproj) has two instances of "sha512module.c" and "signalmodule.c".  While this is harmless, it is also totally unnecessary.  The only change was to remove those two files.

I built all four exes (python|python_d built with vc6|vc7) and ran the regression tests on them.  They passed all expected tests except for the four modules I didn't build (tcl, sqlite, bz2, and bsddb).

The patch is in the form of a zip file containing the build files themselves rather than a patch.  This is because PC/VC6/pythoncore.dsp is marked as a binary file in svn, so "svn diff" declined to produce a good diff.  I'm not sure *why* the file is marked this way; perhaps it's overly sensitive to EOL conventions?  Anyway, I thought it best to honor this, and it was simpler to submit both as a single zip than as a zip and a patch, so here you are.

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2006-10-15 09:57

Message:
Logged In: YES 
user_id=21627

Thanks for the patch; committed as 52333 and 52334. If you
want to contribute further changes, please create a new issue.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-10-15 07:53

Message:
Logged In: YES 
user_id=21627

The tests shouldn't be failing: the should be listed as
(unexpected) skips. Whether or not you want to contribute
project files for ET and ctypes is your choice: it will get
fixed *only* if somebody contributes a fix, OTOH, it's not
probably not important it gets fixed.

As for the base revisions: you did it in a reasonable
manner; I managed to ignore it regardless. I didn't think
about the long file name (only recognized the first few
letters, then shell completion took over), and I routinely
ignore the file description, because people typically don't
fill in something useful, anyway :-(

----------------------------------------------------------------------

Comment By: Larry Hastings (lhastings)
Date: 2006-10-15 01:08

Message:
Logged In: YES 
user_id=364875

Oh, and, I thought I *had* been pretty good at indicating the base revision I was using.  The first file I uploaded was called "lch.python.52326.win32.build.fixes.zip", and its description read "Two project files for pythoncore, based on trunk version 52326."  I indicated the SVN revision number in both places.

What more should I have done?

----------------------------------------------------------------------

Comment By: Larry Hastings (lhastings)
Date: 2006-10-15 01:06

Message:
Logged In: YES 
user_id=364875

Okay, I've uploaded a patch for PCbuild/pythoncore.vcproj against the current 2.6 trunk, and a replacement PC/VC6/pythoncore.dsp for Python 2.5.  You should still get the replacement PC/VC6/pythoncore.dsp for the 2.6 trunk from the first zip file I posted.

One side note: when I build from scratch using VC7, and run "rt.bat", four tests fail because I don't have the libraries to build their modules: bz2, bsddb, tcl, and sqlite.  When I build from scratch using VC6, those four tests fail, and two *more* fail: ctypes and xml_etree_c.  This isn't all that surprising, as ElementTree and ctypes were new additions for 2.5.  Since nobody was maintaining the VC6 build process, they didn't get new build processes made for them.

I could take a stab at making ElementTree and ctypes build in VC6 for 2.5 and the (2.6) trunk if you like.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2006-10-14 21:49

Message:
Logged In: YES 
user_id=21627

The file is marked binary because it was that way in CVS; it
was binary in CVS because not making it binary would cause a
Unix checkout to use Unix EOL (i.e. LF only). That, in turn
would cause VC to reject the files. Since the release
tarball is made on Unix, it would have cause the released
version not to build with VC.

Patching over the entire file is fine in this case. Please
indicate the base revision you had been using. For
pythoncore.vcproj, svn should allow you to create a patch,
though.

Also, please do provide a backport for 2.5; I will then
apply them all simultaneously (or shortly after another).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1576954&group_id=5470