[Patches] [ python-Patches-1695862 ] Fix test_urllib on Windows buildbots

[SourceForge.net]

Patches item #1695862, was opened at 2007-04-07 01:03
Message generated for change (Comment added) made by zseil
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1695862&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tests
Group: Python 2.6
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ziga Seilnacht (zseil)
Assigned to: Ziga Seilnacht (zseil)
Summary: Fix test_urllib on Windows buildbots

Initial Comment:
test_urllib is currently failing on Windows buildbots
because test_os at one time created a directory named
test_support.TESTFN + ".2".  test_os has been fixed,
but the old directory is still present on buildbots.

This patch is a one time fix that should be removed
after the first succesful buildbot run.  I added the
cleanup code to test_urllib, because buildbots run
tests in random order.

The other option is to ask the buildbot slave
maintainers to manually remove the offending directory.



----------------------------------------------------------------------

>Comment By: Ziga Seilnacht (zseil)
Date: 2007-04-09 22:15

Message:
Logged In: YES 
user_id=1326842
Originator: YES

I checked in the first patch, and it fixed the problem on
the Windows 2000 buildbot slave.  I'm not entirely sure how
the buildbot works, so I would like to wait with the second
patch until the Windows XP slave comes back online.

The test was failing only on the trunk, so there is no
need to backport this change.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2007-04-09 20:10

Message:
Logged In: YES 
user_id=33168
Originator: NO

Ziga, if this passes on windows, please apply to trunk.  2.5 branch is
stilly frozen (I forget if this is trunk only). Thanks for backing out my
changes.  They never did much.

----------------------------------------------------------------------

Comment By: Ziga Seilnacht (zseil)
Date: 2007-04-07 01:06

Message:
Logged In: YES 
user_id=1326842
Originator: YES

Here is the second patch that should be applied
once the first one has done its job.  It also
removes Neal's cleanups, because they are not
needed anymore.
File Added: cleanup_cleanup.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1695862&group_id=5470