[Patches] [ python-Patches-1698915 ] ZipFile.printdir fix (2.5)

SourceForge.net noreply at sourceforge.net
Thu Apr 19 08:22:04 CEST 2007


Patches item #1698915, was opened at 2007-04-11 20:22
Message generated for change (Comment added) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1698915&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.5
>Status: Closed
>Resolution: Duplicate
Priority: 5
Private: No
Submitted By: Alan McIntyre (alanmcintyre)
Assigned to: Nobody/Anonymous (nobody)
Summary: ZipFile.printdir fix (2.5)

Initial Comment:
This patch for 2.5 is in reference to bug [ 1698398 ] - "wrong % of params for format string in ZipFile.printdir()."  It makes the following changes:

- Modify ZipFile.printdir() to treat the ZipInfo.date_time object in a way that is similar to other code in zipfile.py.

- Modified ZipFile.writestr() to pass a 6-item tuple to the ZipInfo constructor (consistent with other treatment of ZipInfo construction in the zipfile module) instead of the full result from time.localtime().

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2007-04-18 23:22

Message:
Logged In: YES 
user_id=33168
Originator: NO

Closing this as a dupe of 1698917.  They are the same patch for either 2.5
or 2.6.  Either patch should apply cleanly to both the trunk and 2.5 branch
(which this fix should applied to).


----------------------------------------------------------------------

Comment By: Alan McIntyre (alanmcintyre)
Date: 2007-04-11 20:27

Message:
Logged In: YES 
user_id=1115903
Originator: YES

I forgot to include that this patch passes regrtest.py -r

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1698915&group_id=5470


More information about the Patches mailing list