[Patches] [ python-Patches-1540869 ] CodeContext visibility

[SourceForge.net]

Patches item #1540869, was opened at 2006-08-15 15:20
Message generated for change (Comment added) made by kbk
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1540869&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: IDLE
Group: Python 2.6
>Status: Closed
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: Jim Jewett (jimjjewett)
Assigned to: Kurt B. Kaiser (kbk)
Summary: CodeContext visibility 

Initial Comment:
CodeContext hardcodes several constants; these two in 
particular make it difficult to visually separate the 
"context" from the top of the regular code. 

Ideally, the measurement would change to something 
like em or ex, but ... this was an improvement.  

Note that the separation is explicitly there in the 
code already; it just doesn't work with the current 
constants.  If the Relesae Manager decides to delay it 
to 2.6 (or backport to 2.4), I won't object.



----------------------------------------------------------------------

>Comment By: Kurt B. Kaiser (kbk)
Date: 2007-02-04 23:04

Message:
Logged In: YES 
user_id=149084
Originator: NO

I agree with Tal Einat on this.

----------------------------------------------------------------------

Comment By: Tal Einat (taleinat)
Date: 2006-12-09 11:51

Message:
Logged In: YES 
user_id=1330769
Originator: NO

Increasing the vertical separation is a possibility, but I think this is
mostly a matter of taste.

Personally, I prefer to differentiate between the code and context with a
different backgroud than to have a large blank separator. (Note that the
background and foreground colors of the context are configurable.)

In any case, just increasing the border ruins the horizontal alignment.
This should be done with 'pady' or by adding a padding frame below the
context window.

----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2006-08-16 13:19

Message:
Logged In: YES 
user_id=764593

ahh ... I hadn't even noticed the (effectively one-
character) horizontal change.  

The change I aimed for (which I thought was the goal of the 
pad frame) was a slight *vertical* separation between the 
parts.  

So definately not until 2.6, and hopefully the eventual 
replacement will be better than what I posted here.  Thank 
you for the clarification.

----------------------------------------------------------------------

Comment By: Jim Jewett (jimjjewett)
Date: 2006-08-16 13:18

Message:
Logged In: YES 
user_id=764593

ahh ... I hadn't even noticed the (effectively one-
character) horizontal change.  

The change I aimed for (which I thought was the goal of the 
pad frame) was a slight *vertical* separation between the 
parts.  

So definately not until 2.6, and hopefully the eventual 
replacement will be better than what I posted here.  Thank 
you for the clarification.

----------------------------------------------------------------------

Comment By: Tal Einat (taleinat)
Date: 2006-08-16 11:40

Message:
Logged In: YES 
user_id=1330769

I originally wrote the code with those constants.

I used those constants because I specifically wanted to line
up the CodeContext code with the code in the main window,
for easier reading. Your patch does the exact opposite - it
pushes the CodeContext code way to the right. IMO, since the
purpose of CodeContext is to have the current scope easily
seen, having the code aligned is vital.

You may prefer dis-alignment because it's easier to tell
CodeContext apart, but that's just a personal preference,
and IMO not something that should be the default behavior of
IDLE.

Personally, I find that CodeContext's different background
color is more than enough to distinguish it from the main
editor window. CodeContext's background and foreground
colors are configurable (in config-extensions), you can
always choose colors you like better.

Tal

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1540869&group_id=5470