[Patches] [ python-Patches-1517891 ] Bug 1514451: zipfile "append" mode should create a file ...

SourceForge.net noreply at sourceforge.net
Tue Feb 13 11:11:23 CET 2007


Patches item #1517891, was opened at 2006-07-06 04:25
Message generated for change (Comment added) made by loewis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1517891&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 2.5
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Thomas Lee (krumms)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bug 1514451: zipfile "append" mode should create a file ...

Initial Comment:
'[ 1514451 ] zipfile "append" mode should create a file
if not present'

I thought this was a logical suggestion. Here's a
patch, including tests.

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2007-02-13 11:11

Message:
Logged In: YES 
user_id=21627
Originator: NO

I think there is a documentation patch missing, also: the documentation
explicitly mentions that mode 'a' means to append to an *existing* file. I
changed the documentation accordingly, and committed the patch as r53766.
Thanks for the contribution!

----------------------------------------------------------------------

Comment By: Ronald Oussoren (ronaldoussoren)
Date: 2006-07-06 10:42

Message:
Logged In: YES 
user_id=580910

This patch looks sane. 

What I don't know is if this qualifies as a bugfix or if this is a new
feature 
(however minor).

----------------------------------------------------------------------

Comment By: Thomas Lee (krumms)
Date: 2006-07-06 04:28

Message:
Logged In: YES 
user_id=315535

It should be noted that the decision not to modify self.mode
(i.e. change it to 'w', which is effectively what we're
doing) was a conscious decision: existing code may depend on
the mode attribute (however unlikely that might be).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1517891&group_id=5470


More information about the Patches mailing list