[pypy-svn] r12085 - pypy/dist/lib-python/modified-2.3.4/test

hpk at codespeak.net hpk at codespeak.net
Sun May 8 22:54:21 CEST 2005


Author: hpk
Date: Sun May  8 22:54:21 2005
New Revision: 12085

Added:
   pypy/dist/lib-python/modified-2.3.4/test/test_tempfile.py
      - copied, changed from r12065, pypy/dist/lib-python/2.3.4/test/test_tempfile.py
   pypy/dist/lib-python/modified-2.3.4/test/tf_inherit_check.py
      - copied unchanged from r12065, pypy/dist/lib-python/2.3.4/test/tf_inherit_check.py
Log:
fixed the last failure in test_tempfile.py which assumed early finalization
via __del__ just for a Testcase.tearDown method, so modified that
to not be dependent on this GC detail.

I also had to copy the unmodified tf_inherit.py because test_tempfile.py
uses it for fd's close-on-exec subprocess tests (this is one of the reasons
why i think that tests should temporarily create such test files somewhere
instead of using files that come along with tests, it's just more 
self-contained).



Copied: pypy/dist/lib-python/modified-2.3.4/test/test_tempfile.py (from r12065, pypy/dist/lib-python/2.3.4/test/test_tempfile.py)
==============================================================================
--- pypy/dist/lib-python/2.3.4/test/test_tempfile.py	(original)
+++ pypy/dist/lib-python/modified-2.3.4/test/test_tempfile.py	Sun May  8 22:54:21 2005
@@ -496,8 +496,9 @@
         self.dir = tempfile.mkdtemp()
 
     def tearDown(self):
+        import shutil
         if self.dir:
-            os.rmdir(self.dir)
+            shutil.rmtree(self.dir) 
             self.dir = None
 
     class mktemped:



More information about the Pypy-commit mailing list