[pypy-svn] r24405 - pypy/dist/pypy/jit

[pedronis at codespeak.net]

Author: pedronis
Date: Wed Mar 15 20:18:55 2006
New Revision: 24405

Modified:
   pypy/dist/pypy/jit/hintrtyper.py
Log:
comment about runtime representation of virtual structure.
maybe things can be simplified, the issue is gc tracking of pointers 
to non-gc struct vs. differences introduced through the timeshifting process.



Modified: pypy/dist/pypy/jit/hintrtyper.py
==============================================================================
--- pypy/dist/pypy/jit/hintrtyper.py	(original)
+++ pypy/dist/pypy/jit/hintrtyper.py	Wed Mar 15 20:18:55 2006
@@ -278,7 +278,13 @@
     def __init__(self, original_concretetype, virtualstructdef, timeshifter):
         self.original_concretetype = original_concretetype
         self.timeshifter = timeshifter
-        self.lowleveltype = timeshifter.r_RedBox.lowleveltype
+        # xxx
+        # this could avoid using a wrapper box completely
+        # which means that if the field are green we could back the original situation
+        # but is unclear whether there are issues with gc tracking for non-gc struct pointer,
+        # likely things are preserved but the timeshifted graph may introduce sufficient
+        # differences to make that a problem
+        self.lowleveltype = timeshifter.r_RedBox.lowleveltype 
         if virtualstructdef.vparent is None:
             self.ENVELOPE = lltype.GcForwardReference()                                 
         self.vstructdef = virtualstructdef