[pypy-svn] r53473 - pypy/dist/pypy/module/posix/test

arigo at codespeak.net arigo at codespeak.net
Sun Apr 6 19:44:27 CEST 2008


Author: arigo
Date: Sun Apr  6 19:44:26 2008
New Revision: 53473

Modified:
   pypy/dist/pypy/module/posix/test/test_posix2.py
Log:
A popen test.  Passes, but shows an issue: it prints a number of
"ignored OSError in method __del__".  They are caused by file.__del__
being invoked exactly between the fork-and-close-all-fds and the execvp.

pypy-c has exactly the same issue.  At the moment it prints the annoying
warnings half of the time just when starting up (because it uses
ctypes.util which calls os.popen()).


Modified: pypy/dist/pypy/module/posix/test/test_posix2.py
==============================================================================
--- pypy/dist/pypy/module/posix/test/test_posix2.py	(original)
+++ pypy/dist/pypy/module/posix/test/test_posix2.py	Sun Apr  6 19:44:26 2008
@@ -234,10 +234,10 @@
 
     if hasattr(__import__(os.name), 'popen'):
         def test_popen(self):
-            skip("Not implemented")
             os = self.posix
-            stream = os.popen('echo 1')
-            assert stream.read() == '1\n'
+            for i in range(5):
+                stream = os.popen('echo 1')
+                assert stream.read() == '1\n'
 
     if hasattr(__import__(os.name), '_getfullpathname'):
         def test__getfullpathname(self):



More information about the Pypy-commit mailing list