[pypy-svn] r54064 - pypy/branch/io-improvements/pypy/translator

[fijal at codespeak.net]

Author: fijal
Date: Wed Apr 23 19:33:39 2008
New Revision: 54064

Modified:
   pypy/branch/io-improvements/pypy/translator/exceptiontransform.py
Log:
Leave XXX


Modified: pypy/branch/io-improvements/pypy/translator/exceptiontransform.py
==============================================================================
--- pypy/branch/io-improvements/pypy/translator/exceptiontransform.py	(original)
+++ pypy/branch/io-improvements/pypy/translator/exceptiontransform.py	Wed Apr 23 19:33:39 2008
@@ -346,6 +346,9 @@
         block.recloseblock(l0, l)
 
         insert_zeroing_op = False
+        # XXX this is not right. it also inserts zero_gc_pointers_inside
+        # XXX on a path that malloc_nonmovable returns null, but does not raise
+        # XXX which might end up with a segfault. But we don't have such gc now
         if spaceop.opname == 'malloc' or spaceop.opname == 'malloc_nonmovable':
             flavor = spaceop.args[1].value['flavor']
             if flavor == 'gc':