[pypy-svn] r55745 - pypy/branch/faster-ctypes/pypy/rlib

fijal at codespeak.net fijal at codespeak.net
Wed Jun 11 04:55:34 CEST 2008


Author: fijal
Date: Wed Jun 11 04:55:32 2008
New Revision: 55745

Modified:
   pypy/branch/faster-ctypes/pypy/rlib/libffi.py
Log:
Leave a comment about possible improvements


Modified: pypy/branch/faster-ctypes/pypy/rlib/libffi.py
==============================================================================
--- pypy/branch/faster-ctypes/pypy/rlib/libffi.py	(original)
+++ pypy/branch/faster-ctypes/pypy/rlib/libffi.py	Wed Jun 11 04:55:32 2008
@@ -446,6 +446,11 @@
         self.funcsym = funcsym
         self.argnum = len(self.argtypes)
         self.pushed_args = 0
+        # XXX consider doing the following:
+        #     1. make this thread-local, so we won't interfere with any
+        #        other thread eventually
+        #     2. consider packing it into a struct, this might yield better
+        #        cache-performance, but don't do this without benchmarking!
         self.ll_args = lltype.malloc(rffi.VOIDPP.TO, self.argnum, flavor='raw')
         for i in range(self.argnum):
             # space for each argument



More information about the Pypy-commit mailing list