[pypy-svn] r54729 - in pypy/dist/pypy/objspace: std/test test

arigo at codespeak.net arigo at codespeak.net
Wed May 14 14:03:27 CEST 2008


Author: arigo
Date: Wed May 14 14:03:25 2008
New Revision: 54729

Modified:
   pypy/dist/pypy/objspace/std/test/test_intobject.py
   pypy/dist/pypy/objspace/test/test_descroperation.py
Log:
Document why these are obscure cases.


Modified: pypy/dist/pypy/objspace/std/test/test_intobject.py
==============================================================================
--- pypy/dist/pypy/objspace/std/test/test_intobject.py	(original)
+++ pypy/dist/pypy/objspace/std/test/test_intobject.py	Wed May 14 14:03:25 2008
@@ -415,7 +415,10 @@
         assert  0 .__getnewargs__() == (0,)
 
     def test_cmp(self):
-        skip("Fails with an AttributeError, works in cpython")
+        skip("This is a 'wont fix' case")
+        # We don't have __cmp__, we consistently have __eq__ & the others
+        # instead.  In CPython some types have __cmp__ and some types have
+        # __eq__ & the others.
         assert 1 .__cmp__
         assert int .__cmp__
 

Modified: pypy/dist/pypy/objspace/test/test_descroperation.py
==============================================================================
--- pypy/dist/pypy/objspace/test/test_descroperation.py	(original)
+++ pypy/dist/pypy/objspace/test/test_descroperation.py	Wed May 14 14:03:25 2008
@@ -320,6 +320,9 @@
 
     def test_setattrweakref(self):
         skip("fails, works in cpython")
+        # The issue is that in CPython, none of the built-in types have
+        # a __weakref__ descriptor, even if their instances are weakrefable.
+        # Should we emulate this?
         class P(object):
             pass
 



More information about the Pypy-commit mailing list