[pypy-svn] r55159 - in pypy/dist/pypy/objspace/std: . test

cfbolz at codespeak.net cfbolz at codespeak.net
Sat May 24 00:00:55 CEST 2008


Author: cfbolz
Date: Sat May 24 00:00:49 2008
New Revision: 55159

Modified:
   pypy/dist/pypy/objspace/std/dictmultiobject.py
   pypy/dist/pypy/objspace/std/test/test_dictmultiobject.py
Log:
fixing the bug is less work than skipping the tests


Modified: pypy/dist/pypy/objspace/std/dictmultiobject.py
==============================================================================
--- pypy/dist/pypy/objspace/std/dictmultiobject.py	(original)
+++ pypy/dist/pypy/objspace/std/dictmultiobject.py	Sat May 24 00:00:49 2008
@@ -1271,7 +1271,7 @@
                 # XXX for now, we cannot use iteritems() at app-level because
                 #     we want a reasonable result instead of a RuntimeError
                 #     even if the dict is mutated by the repr() in the loop.
-                for k, v in d.items():
+                for k, v in dict.items(d):
                     items.append(repr(k) + ": " + repr(v))
                 return "{" +  ', '.join(items) + "}"
             finally:

Modified: pypy/dist/pypy/objspace/std/test/test_dictmultiobject.py
==============================================================================
--- pypy/dist/pypy/objspace/std/test/test_dictmultiobject.py	(original)
+++ pypy/dist/pypy/objspace/std/test/test_dictmultiobject.py	Sat May 24 00:00:49 2008
@@ -31,8 +31,6 @@
     def test_emptydict_unhashable(self):
         raises(TypeError, "{}[['x']]")
 
-    def test_repr_with_overriden_items(self):
-        skip("XXX broken!!!")
 
 class TestW_DictSharing(test_dictobject.TestW_DictObject):
     def setup_class(cls):
@@ -60,8 +58,6 @@
         a.__dict__.items() == [("abc", 12)]
 
 
-    def test_repr_with_overriden_items(self):
-        skip("XXX broken!!!")
 
 class TestW_DictSmall(test_dictobject.TestW_DictObject):
     def setup_class(cls):
@@ -71,8 +67,6 @@
     def setup_class(cls):
         cls.space = gettestobjspace(**{"objspace.std.withsmalldicts": True})
 
-    def test_repr_with_overriden_items(self):
-        skip("XXX broken!!!")
 
 class C: pass
 



More information about the Pypy-commit mailing list