[pypy-svn] r69946 - pypy/trunk/pypy/objspace/std

cfbolz at codespeak.net cfbolz at codespeak.net
Mon Dec 7 15:36:24 CET 2009


Author: cfbolz
Date: Mon Dec  7 15:36:22 2009
New Revision: 69946

Modified:
   pypy/trunk/pypy/objspace/std/inlinedict.py
Log:
make comment sound less dangerous


Modified: pypy/trunk/pypy/objspace/std/inlinedict.py
==============================================================================
--- pypy/trunk/pypy/objspace/std/inlinedict.py	(original)
+++ pypy/trunk/pypy/objspace/std/inlinedict.py	Mon Dec  7 15:36:22 2009
@@ -96,7 +96,9 @@
 
         def setdictvalue(self, space, attr, w_value, shadows_type=True):
             if self._inlined_dict_valid():
-                # XXX don't ignore shadows_type
+                # XXX so far we ignore shadows_type, which is a small
+                # performance-degradation if the JIT is not used (i.e. shadow
+                # tracking does not work). Maybe we don't care.
                 self.impl_setitem_str(attr, w_value)
                 return True
             w_dict = self.getdict()



More information about the Pypy-commit mailing list