[pypy-svn] r64937 - in pypy/build/bot2/pypybuildbot: . test

[pedronis at codespeak.net]

Author: pedronis
Date: Fri May  1 13:27:07 2009
New Revision: 64937

Modified:
   pypy/build/bot2/pypybuildbot/summary.py
   pypy/build/bot2/pypybuildbot/test/test_summary.py
Log:
always fill in the success meta-line

Modified: pypy/build/bot2/pypybuildbot/summary.py
==============================================================================
--- pypy/build/bot2/pypybuildbot/summary.py	(original)
+++ pypy/build/bot2/pypybuildbot/summary.py	Fri May  1 13:27:07 2009
@@ -393,12 +393,14 @@
         if self.SUCCESS_LINE:
             success = []
             for label, outcome_set in by_label:
-                if not outcome_set.failed:
-                    success.append([" ",
-                                 html.span("+",
-                                           class_="failSummary success")])
-                else:
-                    success.append("  ")
+                symbol = "+"
+                clazz = "success"
+                if outcome_set.failed:
+                    symbol = "-"
+                    clazz = "failed"
+                success.append([" ",
+                                html.span(symbol,
+                                          class_="failSummary "+clazz)])
             success.append("  success\n")
             lines.append(success)
             

Modified: pypy/build/bot2/pypybuildbot/test/test_summary.py
==============================================================================
--- pypy/build/bot2/pypybuildbot/test/test_summary.py	(original)
+++ pypy/build/bot2/pypybuildbot/test/test_summary.py	Fri May  1 13:27:07 2009
@@ -474,7 +474,7 @@
 
         assert 'TEST1' in out
         assert ':-)' in out
-        assert '\n   <span class="failSummary success">+</span>  success' in out   
+        assert '\n <span class="failSummary failed">-</span> <span class="failSummary success">+</span>  success' in out   
 
     def test_two_builds_samerev(self):
         builder = status_builder.BuilderStatus('builder0')