[pypy-svn] r68892 - pypy/trunk/pypy/jit/metainterp/test

arigo at codespeak.net arigo at codespeak.net
Sun Nov 1 16:38:22 CET 2009


Author: arigo
Date: Sun Nov  1 16:38:22 2009
New Revision: 68892

Modified:
   pypy/trunk/pypy/jit/metainterp/test/test_vlist.py
Log:
Remove the py.test.xfail and replace it with a skip.  It took me a while
to figure out that the test is not actually supposed to completely fail,
but just the check_loops() at the end.  The construction works fine,
it's just that it needs a residual call so far.



Modified: pypy/trunk/pypy/jit/metainterp/test/test_vlist.py
==============================================================================
--- pypy/trunk/pypy/jit/metainterp/test/test_vlist.py	(original)
+++ pypy/trunk/pypy/jit/metainterp/test/test_vlist.py	Sun Nov  1 16:38:22 2009
@@ -97,9 +97,9 @@
         assert res == f(10)
         self.check_loops(setarrayitem_gc=0, getarrayitem_gc=0, call=0)
 
-    @py.test.mark.xfail
     def test_vlist_alloc_and_set(self):
-        # this fails, because [non-null] * n is not supported yet
+        # the check_loops fails, because [non-null] * n is not supported yet
+        # (it is implemented as a residual call)
         jitdriver = JitDriver(greens = [], reds = ['n'])
         def f(n):
             l = [1] * 20
@@ -116,6 +116,7 @@
 
         res = self.meta_interp(f, [10], listops=True)
         assert res == f(10)
+        py.test.skip("'[non-null] * n' gives a residual call so far")
         self.check_loops(setarrayitem_gc=0, getarrayitem_gc=0, call=0)
         
     def test_append_pop(self):



More information about the Pypy-commit mailing list