[pypy-svn] r69559 - pypy/branch/compress-virtuals-resumedata2/pypy/jit/backend/x86

pedronis at codespeak.net pedronis at codespeak.net
Mon Nov 23 17:30:40 CET 2009


Author: pedronis
Date: Mon Nov 23 17:30:40 2009
New Revision: 69559

Modified:
   pypy/branch/compress-virtuals-resumedata2/pypy/jit/backend/x86/assembler.py
   pypy/branch/compress-virtuals-resumedata2/pypy/jit/backend/x86/regalloc.py
Log:
comment places that need some rethinking when merged with the shorter-guard-path, not clear is worth improving them now

Modified: pypy/branch/compress-virtuals-resumedata2/pypy/jit/backend/x86/assembler.py
==============================================================================
--- pypy/branch/compress-virtuals-resumedata2/pypy/jit/backend/x86/assembler.py	(original)
+++ pypy/branch/compress-virtuals-resumedata2/pypy/jit/backend/x86/assembler.py	Mon Nov 23 17:30:40 2009
@@ -738,7 +738,7 @@
         """ assert that all args are actually Boxes
         """
         for arg in args:
-            assert arg is None or isinstance(arg, Box)
+            assert arg is None or isinstance(arg, Box) # hole
 
     def implement_guard_recovery(self, guard_opnum, faildescr, failargs,
                                                                fail_locs):
@@ -754,7 +754,7 @@
         pos = mc.tell()
         for i in range(len(failargs)):
             arg = failargs[i]
-            if arg is None:
+            if arg is None: # hole
                 continue
             loc = locs[i]
             if isinstance(loc, REG):
@@ -769,7 +769,7 @@
                     mc.MOV(heap(adr), loc)
         for i in range(len(failargs)):
             arg = failargs[i]
-            if arg is None:
+            if arg is None: # hole
                 continue
             loc = locs[i]
             if not isinstance(loc, REG):

Modified: pypy/branch/compress-virtuals-resumedata2/pypy/jit/backend/x86/regalloc.py
==============================================================================
--- pypy/branch/compress-virtuals-resumedata2/pypy/jit/backend/x86/regalloc.py	(original)
+++ pypy/branch/compress-virtuals-resumedata2/pypy/jit/backend/x86/regalloc.py	Mon Nov 23 17:30:40 2009
@@ -203,7 +203,7 @@
 
     def possibly_free_vars(self, vars):
         for var in vars:
-            if var is not None:
+            if var is not None: # xxx kludgy
                 self.possibly_free_var(var)
 
     def make_sure_var_in_reg(self, var, forbidden_vars=[],
@@ -379,7 +379,7 @@
         return longevity
 
     def loc(self, v):
-        if v is None:
+        if v is None: # xxx kludgy
             return None
         if v.type == FLOAT:
             return self.xrm.loc(v)



More information about the Pypy-commit mailing list