[pypy-svn] r73719 - pypy/trunk/pypy/jit/metainterp

arigo at codespeak.net arigo at codespeak.net
Tue Apr 13 14:21:22 CEST 2010


Author: arigo
Date: Tue Apr 13 14:21:21 2010
New Revision: 73719

Modified:
   pypy/trunk/pypy/jit/metainterp/optimizefindnode.py
Log:
(cfbolz, arigo)

Clarify the purpose of that strange line.  Preparation for the upcoming
fix, too.



Modified: pypy/trunk/pypy/jit/metainterp/optimizefindnode.py
==============================================================================
--- pypy/trunk/pypy/jit/metainterp/optimizefindnode.py	(original)
+++ pypy/trunk/pypy/jit/metainterp/optimizefindnode.py	Tue Apr 13 14:21:21 2010
@@ -63,13 +63,14 @@
         # invariant: if escaped=True, then dependencies is None
         if not self.escaped:
             self.escaped = True
+            self.unique = UNIQUE_NO
+            # ^^^ always set unique to UNIQUE_NO when we set escaped to True.
+            # See for example test_find_nodes_store_into_loop_constant_2.
             if self.dependencies is not None:
                 deps = self.dependencies
                 self.dependencies = None
                 for box in deps:
                     box.mark_escaped()
-                    # see test_find_nodes_store_into_loop_constant_1 for this:
-                    box.unique = UNIQUE_NO
 
     def set_unique_nodes(self):
         if self.fromstart:



More information about the Pypy-commit mailing list