[pypy-commit] [COMMENT] Pull request #8 for pypy/pypy: added numpy.sort, tests, and docstring for numpy.array.sort
notifications-noreply at bitbucket.org
Sun Aug 28 08:32:52 CEST 2011
New comment on pull request:
Alex Gaynor (alex_gaynor) said:
Sorry, here are the issues I saw:
* It would need to be rewritten after the merge of the dtypes branch (which rewrites most of everything :P)
* It doesn't work with any of the virtual arrays (I'm surprised it even translates)
* It looks like a pretty simple quicksort, which means it can have performance issues (I'd like to try using the TimSort we already have)
* There are stylistic issues, semicolons, and excessive parens mostly.
This is a pull request comment notification from bitbucket.org.
You are receiving this either because you are participating
in a pull request, or you are following it.
More information about the pypy-commit