[pypy-commit] pypy numpy-dtype-refactor: add REVIEW notes

fijal noreply at buildbot.pypy.org
Fri Dec 2 08:28:50 CET 2011

Author: Maciej Fijalkowski <fijall at gmail.com>
Branch: numpy-dtype-refactor
Changeset: r50053:8bfca97d2a5c
Date: 2011-12-02 09:28 +0200

Log:	add REVIEW notes

diff --git a/pypy/module/micronumpy/REVIEW b/pypy/module/micronumpy/REVIEW
new file mode 100644
--- /dev/null
+++ b/pypy/module/micronumpy/REVIEW
@@ -0,0 +1,5 @@
+* Why we pass __module__ = 'numpy' to typedefs? Most stuff in pypy has
+  __module__ == '__builtin__' for good or bad, but if so, we should pass numpypy
+* why int16/int32 are not exported in __init__.py?
+* W_GenericBox.descr_int is not tested
+* setitem_w no longer calls invalidated(), why? doesn't it break some stuff?

More information about the pypy-commit mailing list