[pypy-commit] pypy refactor-signature: my review notes

alex_gaynor noreply at buildbot.pypy.org
Tue Dec 20 01:11:35 CET 2011

Author: Alex Gaynor <alex.gaynor at gmail.com>
Branch: refactor-signature
Changeset: r50735:feddaef940ac
Date: 2011-12-19 18:11 -0600

Log:	my review notes

diff --git a/pypy/module/micronumpy/REVIEW.txt b/pypy/module/micronumpy/REVIEW.txt
new file mode 100644
--- /dev/null
+++ b/pypy/module/micronumpy/REVIEW.txt
@@ -0,0 +1,16 @@
+* Scalar.reshape should turn the value into an array correct for an input of
+  ``1`` or ``(1,)``.
+* VirtualSlice vs. W_NDimSlice?
+* Call{1, 2}.create_sig, should it call forced_result.create_sig(), instead of
+  array_sig()? If not, why not?
+* W_NDimSlice.__init__ calls ConcreteArray.__init__ instead of
+  ViewArray.__init__, W_FlatIterator as well.
+* Better names for sigeq and sigeq2, sighash doesn't say if numberings are
+  included in the hash.
+* Cleanup of the iterator and array caching/numbering.  It's a mess right now:
+  * _creater_iter updates the arraylist
+  * Why do Scalars need an iterator at all?
+  * Do views share storage with concrete arrays or other views?

More information about the pypy-commit mailing list