[pypy-svn] pypy default: kill old and very obscure function

cfbolz commits-noreply at bitbucket.org
Tue Jan 4 18:09:55 CET 2011


Author: Carl Friedrich Bolz <cfbolz at gmx.de>
Branch: 
Changeset: r40390:e1ab35394b0f
Date: 2011-01-04 18:11 +0100
http://bitbucket.org/pypy/pypy/changeset/e1ab35394b0f/

Log:	kill old and very obscure function

diff --git a/pypy/annotation/annrpython.py b/pypy/annotation/annrpython.py
--- a/pypy/annotation/annrpython.py
+++ b/pypy/annotation/annrpython.py
@@ -406,31 +406,6 @@
 
     #___ simplification (should be moved elsewhere?) _______
 
-    # it should be!
-    # now simplify_calls is moved to transform.py.
-    # i kept reverse_binding here for future(?) purposes though. --sanxiyn
-
-    def reverse_binding(self, known_variables, cell):
-        """This is a hack."""
-        # In simplify_calls, when we are trying to create the new
-        # SpaceOperation, all we have are SomeValues.  But SpaceOperations take
-        # Variables, not SomeValues.  Trouble is, we don't always have a
-        # Variable that just happens to be bound to the given SomeValue.
-        # A typical example would be if the tuple of arguments was created
-        # from another basic block or even another function.  Well I guess
-        # there is no clean solution, short of making the transformations
-        # more syntactic (e.g. replacing a specific sequence of SpaceOperations
-        # with another one).  This is a real hack because we have to use
-        # the identity of 'cell'.
-        if cell.is_constant():
-            return Constant(cell.const)
-        else:
-            for v in known_variables:
-                if self.bindings[v] is cell:
-                    return v
-            else:
-                raise CannotSimplify
-
     def simplify(self, block_subset=None, extra_passes=None):
         # Generic simplifications
         transform.transform_graph(self, block_subset=block_subset,
@@ -783,10 +758,6 @@
 RPythonAnnotator._registeroperations(annmodel)
 
 
-class CannotSimplify(Exception):
-    pass
-
-
 class BlockedInference(Exception):
     """This exception signals the type inference engine that the situation
     is currently blocked, and that it should try to progress elsewhere."""


More information about the Pypy-commit mailing list