[pypy-commit] pypy default: bah, these two tests weren't actually test anything. test_python_contains fails

[antocuni]

Author: Antonio Cuni <anto.cuni at gmail.com>
Branch: 
Changeset: r44733:a0369628bd33
Date: 2011-06-06 13:40 +0200
http://bitbucket.org/pypy/pypy/changeset/a0369628bd33/

Log:	bah, these two tests weren't actually test anything.
	test_python_contains fails

diff --git a/pypy/module/pypyjit/test_pypy_c/test_pypy_c_new.py b/pypy/module/pypyjit/test_pypy_c/test_pypy_c_new.py
--- a/pypy/module/pypyjit/test_pypy_c/test_pypy_c_new.py
+++ b/pypy/module/pypyjit/test_pypy_c/test_pypy_c_new.py
@@ -1698,7 +1698,7 @@
 
         log = self.run(main, [], threshold=80)
         loop, = log.loops_by_filename(self.filepath)
-        loop.match_by_id('loadattr',
+        assert loop.match_by_id('loadattr',
         '''
         guard_not_invalidated(descr=...)
         i19 = call(ConstClass(ll_dict_lookup), _, _, _, descr=...)
@@ -1724,13 +1724,13 @@
             while i < 100:
                 i += i in a # ID: contains
 
-            log = self.run(main, [], threshold=80)
-            loop, = log.loops_by_filename(self.filemath)
-            # XXX: haven't confirmed his is correct, it's probably missing a
-            # few instructions
-            loop.match_by_id("contains", """
-                i1 = int_add(i0, 1)
-            """)
+        log = self.run(main, [], threshold=80)
+        loop, = log.loops_by_filename(self.filepath)
+        # XXX: haven't confirmed his is correct, it's probably missing a
+        # few instructions
+        assert loop.match_by_id("contains", """
+            i1 = int_add(i0, 1)
+        """)
 
     def test_dont_trace_every_iteration(self):
         def main(a, b):