[pypy-commit] pypy default: The call Random(0) should not leave the Random object uninitialized.

arigo noreply at buildbot.pypy.org
Thu Jun 9 09:22:20 CEST 2011


Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r44845:51da2cb6569e
Date: 2011-06-09 09:23 +0200
http://bitbucket.org/pypy/pypy/changeset/51da2cb6569e/

Log:	The call Random(0) should not leave the Random object uninitialized.
	Test and fix.

diff --git a/pypy/rlib/rrandom.py b/pypy/rlib/rrandom.py
--- a/pypy/rlib/rrandom.py
+++ b/pypy/rlib/rrandom.py
@@ -24,8 +24,7 @@
     def __init__(self, seed=r_uint(0)):
         self.state = [r_uint(0)] * N
         self.index = 0
-        if seed:
-            self.init_genrand(seed)
+        self.init_genrand(seed)
 
     def init_genrand(self, s):
         mt = self.state
diff --git a/pypy/rlib/test/test_rrandom.py b/pypy/rlib/test/test_rrandom.py
--- a/pypy/rlib/test/test_rrandom.py
+++ b/pypy/rlib/test/test_rrandom.py
@@ -3,6 +3,12 @@
 
 # the numbers were created by using CPython's _randommodule.c
 
+def test_init_from_zero():
+    rnd = Random(0)
+    assert rnd.state[:14] == [0, 1, 1812433255, 1900727105, 1208447044,
+            2481403966, 4042607538, 337614300, 3232553940,
+            1018809052, 3202401494, 1775180719, 3192392114, 594215549]
+
 def test_init_from_seed():
     rnd = Random(1000)
     assert rnd.state[:14] == [1000, 4252021385, 1724402292, 571538732,


More information about the pypy-commit mailing list