[pypy-commit] pypy applevel-builder: Remove special case, it would could create silly bridge, if we need it we can add an append_char method (or make the JIT recognize the method and virtual strings of known length 1).

alex_gaynor noreply at buildbot.pypy.org
Wed Jun 22 03:18:59 CEST 2011


Author: Alex Gaynor <alex.gaynor at gmail.com>
Branch: applevel-builder
Changeset: r45052:1fd3637e2f95
Date: 2011-06-21 18:23 -0700
http://bitbucket.org/pypy/pypy/changeset/1fd3637e2f95/

Log:	Remove special case, it would could create silly bridge, if we need
	it we can add an append_char method (or make the JIT recognize the
	method and virtual strings of known length 1).

diff --git a/pypy/module/__pypy__/interp_builders.py b/pypy/module/__pypy__/interp_builders.py
--- a/pypy/module/__pypy__/interp_builders.py
+++ b/pypy/module/__pypy__/interp_builders.py
@@ -24,10 +24,7 @@
     @unwrap_spec(s=unicode)
     def descr_append(self, space, s):
         self._check_done(space)
-        if len(s) == 1:
-            self.builder.append(s[0])
-        else:
-            self.builder.append(s)
+        self.builder.append(s)
 
     @unwrap_spec(s=unicode, start=int, end=int)
     def descr_append_slice(self, space, s, start, end):


More information about the pypy-commit mailing list