[pypy-commit] pypy win64_gborg: This fix looks wrong. The JMP target is still only 4 bytes even

arigo noreply at buildbot.pypy.org
Thu Nov 10 13:42:44 CET 2011


Author: Armin Rigo <arigo at tunes.org>
Branch: win64_gborg
Changeset: r49132:697e191ea0e0
Date: 2011-11-10 13:42 +0100
http://bitbucket.org/pypy/pypy/changeset/697e191ea0e0/

Log:	This fix looks wrong. The JMP target is still only 4 bytes even in
	AMD64 assembler.

diff --git a/pypy/rpython/memory/gctransform/asmgcroot.py b/pypy/rpython/memory/gctransform/asmgcroot.py
--- a/pypy/rpython/memory/gctransform/asmgcroot.py
+++ b/pypy/rpython/memory/gctransform/asmgcroot.py
@@ -533,6 +533,7 @@
         # The initial gcmap table contains addresses to a JMP
         # instruction that jumps indirectly to the real code.
         # Replace them with the target addresses.
+        assert rffi.SIGNEDP is rffi.LONGP, "win64 support missing"
         while start < end:
             code = rffi.cast(rffi.CCHARP, start.address[0])[0]
             if code == '\xe9': # jmp


More information about the pypy-commit mailing list