[pypy-commit] pypy set-strategies: removed/chnaged old comments

l.diekmann noreply at buildbot.pypy.org
Thu Nov 10 13:51:08 CET 2011


Author: Lukas Diekmann <lukas.diekmann at uni-duesseldorf.de>
Branch: set-strategies
Changeset: r49198:534d51292ce2
Date: 2011-08-23 12:01 +0200
http://bitbucket.org/pypy/pypy/changeset/534d51292ce2/

Log:	removed/chnaged old comments

diff --git a/pypy/objspace/std/setobject.py b/pypy/objspace/std/setobject.py
--- a/pypy/objspace/std/setobject.py
+++ b/pypy/objspace/std/setobject.py
@@ -1085,9 +1085,7 @@
 set_isdisjoint__Frozenset_Set = set_isdisjoint__Set_Set
 
 def set_isdisjoint__Set_ANY(space, w_left, w_other):
-    #XXX maybe checking if type fits strategy first (before comparing) speeds this up a bit
-    #    since this will be used in many other functions -> general function for that
-    # if w_left.strategy != w_other.strategy => return w_False
+    #XXX may be optimized when other strategies are added
     for w_key in space.listview(w_other):
         if w_left.has_key(w_key):
             return space.w_False
@@ -1112,8 +1110,6 @@
 
 
 def set_symmetric_difference__Set_ANY(space, w_left, w_other):
-    #XXX since we need to iterate over both objects, create set
-    #    from w_other so looking up items is fast
     w_other_as_set = w_left._newobj(space, w_other)
     w_result = w_left.symmetric_difference(w_other_as_set)
     return w_result


More information about the pypy-commit mailing list