[pypy-commit] pypy default: issue1116: No objection, so go ahead and fix interp_iobase, even

arigo noreply at buildbot.pypy.org
Mon Aug 27 21:29:39 CEST 2012


Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r56888:52f958893e11
Date: 2012-08-27 21:29 +0200
http://bitbucket.org/pypy/pypy/changeset/52f958893e11/

Log:	issue1116: No objection, so go ahead and fix interp_iobase, even
	though I don't really know it.

diff --git a/pypy/module/_io/interp_iobase.py b/pypy/module/_io/interp_iobase.py
--- a/pypy/module/_io/interp_iobase.py
+++ b/pypy/module/_io/interp_iobase.py
@@ -326,13 +326,11 @@
             try:
                 space.call_method(w_iobase, 'flush')
             except OperationError, e:
-                # if it's an IOError or ValueError, ignore it (ValueError is
-                # raised if by chance we are trying to flush a file which has
-                # already been closed)
-                if not (e.match(space, space.w_IOError) or
-                        e.match(space, space.w_ValueError)):
-                    raise
-        
+                # Silencing all errors is bad, but getting randomly
+                # interrupted here is equally as bad, and potentially
+                # more frequent (because of shutdown issues).
+                pass 
+
 
 class AutoFlusher(object):
     


More information about the pypy-commit mailing list