[pypy-commit] pypy default: Comment (derived from pypy-dev).

arigo noreply at buildbot.pypy.org
Tue Feb 21 18:01:04 CET 2012


Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r52741:48ef6cd6e2df
Date: 2012-02-21 18:00 +0100
http://bitbucket.org/pypy/pypy/changeset/48ef6cd6e2df/

Log:	Comment (derived from pypy-dev).

diff --git a/pypy/objspace/std/dictmultiobject.py b/pypy/objspace/std/dictmultiobject.py
--- a/pypy/objspace/std/dictmultiobject.py
+++ b/pypy/objspace/std/dictmultiobject.py
@@ -143,6 +143,10 @@
                 return result
 
     def popitem(self, w_dict):
+        # this is a bad implementation: if we call popitem() repeatedly,
+        # it ends up taking n**2 time, because the next() calls below
+        # will take longer and longer.  But all interesting strategies
+        # provide a better one.
         space = self.space
         iterator = self.iter(w_dict)
         w_key, w_value = iterator.next()


More information about the pypy-commit mailing list