[pypy-commit] pypy speedup-list-comprehension: review notes

alex_gaynor noreply at buildbot.pypy.org
Sat Feb 25 02:38:53 CET 2012


Author: Alex Gaynor <alex.gaynor at gmail.com>
Branch: speedup-list-comprehension
Changeset: r52894:af87de586204
Date: 2012-02-24 20:38 -0500
http://bitbucket.org/pypy/pypy/changeset/af87de586204/

Log:	review notes

diff --git a/REVIEW.rst b/REVIEW.rst
new file mode 100644
--- /dev/null
+++ b/REVIEW.rst
@@ -0,0 +1,10 @@
+Review notes
+============
+
+
+* explicit tests for the generated bytecode
+* BUILD_LIST_FROM_ARG shouldn't absort async exceptions
+* dead code in jit/codewriter/support.py?
+* Do we need __length_hint__?
+* len_w instead of int_w(len())
+* share some code with _unpackiterable_unknown_length


More information about the pypy-commit mailing list