[pypy-commit] pypy speedup-list-comprehension: improve the comment

fijal noreply at buildbot.pypy.org
Sun Feb 26 05:02:43 CET 2012


Author: Maciej Fijalkowski <fijall at gmail.com>
Branch: speedup-list-comprehension
Changeset: r52909:9ac6f6b1f4eb
Date: 2012-02-25 20:01 -0800
http://bitbucket.org/pypy/pypy/changeset/9ac6f6b1f4eb/

Log:	improve the comment

diff --git a/pypy/jit/metainterp/test/test_list.py b/pypy/jit/metainterp/test/test_list.py
--- a/pypy/jit/metainterp/test/test_list.py
+++ b/pypy/jit/metainterp/test/test_list.py
@@ -256,6 +256,7 @@
             return a * b
         res = self.meta_interp(f, [37])
         assert res == f(37)
-        # There is the one actual field on a, plus several fields on the list
-        # itself
+        # by unrolling there should be no actual getfields on a in the
+        # loop. if caches were invalidated, there will be 2.
+        # getfields are 2 reads of items and 2 of length
         self.check_simple_loop(getfield_gc=4)


More information about the pypy-commit mailing list