[pypy-commit] pypy numppy-flatitter: add REVIEW

fijal noreply at buildbot.pypy.org
Thu Jan 19 18:11:24 CET 2012

Author: Maciej Fijalkowski <fijall at gmail.com>
Branch: numppy-flatitter
Changeset: r51494:3a1f1a964ab4
Date: 2012-01-19 19:10 +0200

Log:	add REVIEW

diff --git a/pypy/module/micronumpy/REVIEW b/pypy/module/micronumpy/REVIEW
new file mode 100644
--- /dev/null
+++ b/pypy/module/micronumpy/REVIEW
@@ -0,0 +1,10 @@
+* I think we should wait for indexing-by-arrays-2, since this would clean up
+  the iterator interface
+* I commited a failing test, it seems the entire approach is pretty doomed.
+  Instead we should keep the parent iterator (and not create a OneDim one)
+* For getitem, we need to reuse parent getitem, but with some hook
+  that recomputes indexes. That hook would be used for any sort of access,
+  be it slices or be it integers, but in general I would like to avoid code
+  duplication, since the indexing is getting slowly fairly complex.
\ No newline at end of file

More information about the pypy-commit mailing list