[pypy-commit] [COMMENT] Pull request #23 for pypy/pypy: Fix _sqlite3.py fix for issue996, with test

Bitbucket notifications-noreply at bitbucket.org
Mon Jan 23 00:12:58 CET 2012


New comment on pull request:

https://bitbucket.org/pypy/pypy/pull-request/23/fix-_sqlite3py-fix-for-issue996-with-test#comment-1996

Alex Gaynor (alex_gaynor) said:

A few comments:

# No need for the new comment at the top of _sqlite3.py, it has already been modified many times :)
# The new tests should probably make an assertion about the contents of result, even if it's just that it's an empty list.

Thanks!

--
This is a pull request comment notification from bitbucket.org.
You are receiving this either because you are participating
in a pull request, or you are following it.


More information about the pypy-commit mailing list