[pypy-commit] pypy stackroot-speedup: Fix.

arigo noreply at buildbot.pypy.org
Sun Jan 29 19:56:56 CET 2012


Author: Armin Rigo <arigo at tunes.org>
Branch: stackroot-speedup
Changeset: r51952:d7ae2df81896
Date: 2012-01-28 21:24 +0100
http://bitbucket.org/pypy/pypy/changeset/d7ae2df81896/

Log:	Fix.

diff --git a/pypy/rpython/memory/gctransform/shadowstack.py b/pypy/rpython/memory/gctransform/shadowstack.py
--- a/pypy/rpython/memory/gctransform/shadowstack.py
+++ b/pypy/rpython/memory/gctransform/shadowstack.py
@@ -392,7 +392,11 @@
         if not prev:
             root_iterator.setcontext(obj.context)
             prev = obj.top
-        return root_iterator.nextleft(gc, obj.base, prev)
+        return root_iterator.nextleft(gc, obj.base, prev,
+                                      is_minor=False)
+        # note: it's probably good enough to pass is_minor=False,
+        # because if the 'obj' stays around for longer, it becomes
+        # itself an old object and is not traced any more at all
 
     CUSTOMTRACEFUNC = lltype.FuncType([llmemory.Address, llmemory.Address],
                                       llmemory.Address)


More information about the pypy-commit mailing list