[pypy-commit] [COMMENT] Pull request #29 for pypy/pypy: Finish kqueue support

[Bitbucket]

New comment on pull request:

https://bitbucket.org/pypy/pypy/pull-request/29/finish-kqueue-support#comment-3541

Alex Gaynor (alex_gaynor) said:

Overal: fantastic work for a first patch! A few small things (I'm anal about this):

# `for symbol in symbol_map.keys():` -> `for symbol in symbols_map`, there's no need for `keys()` call.
# Can you remove the comments with the C declarations? They're distracting, and don't add much since the llexternal call has the same API (of course)
# Line 208, w_elist, that should elist_w. _w suffix means that it's an RPython list of interpreter objects.
# Right now kevents can only be compared by ==, <, and >=.  This probably needs to add <=, >, and !=, right?

Great work!

--
This is a pull request comment notification from bitbucket.org.
You are receiving this either because you are participating
in a pull request, or you are following it.