[pypy-commit] pypy speedup-list-comprehension: backout wrong fix

fijal noreply at buildbot.pypy.org
Fri Mar 9 19:20:58 CET 2012


Author: Maciej Fijalkowski <fijall at gmail.com>
Branch: speedup-list-comprehension
Changeset: r53286:16cac49dc8ed
Date: 2012-03-08 17:07 -0800
http://bitbucket.org/pypy/pypy/changeset/16cac49dc8ed/

Log:	backout wrong fix

diff --git a/pypy/jit/metainterp/test/test_list.py b/pypy/jit/metainterp/test/test_list.py
--- a/pypy/jit/metainterp/test/test_list.py
+++ b/pypy/jit/metainterp/test/test_list.py
@@ -256,7 +256,6 @@
             return a * b
         res = self.meta_interp(f, [37])
         assert res == f(37)
-        # by unrolling there should be no actual getfields on a in the
-        # loop. if caches were invalidated, there will be 2.
-        # getfields are 2 reads of items and 2 of length
-        self.check_simple_loop(getfield_gc=4)
+        # There is the one actual field on a, plus several fields on the list
+        # itself
+        self.check_resops(getfield_gc=10)


More information about the pypy-commit mailing list