[pypy-commit] pypy py3k: fix this test and add a comment

antocuni noreply at buildbot.pypy.org
Wed Mar 21 12:27:42 CET 2012


Author: Antonio Cuni <anto.cuni at gmail.com>
Branch: py3k
Changeset: r53864:2186005942d0
Date: 2012-03-21 12:26 +0100
http://bitbucket.org/pypy/pypy/changeset/2186005942d0/

Log:	fix this test and add a comment

diff --git a/pypy/objspace/std/test/test_obj.py b/pypy/objspace/std/test/test_obj.py
--- a/pypy/objspace/std/test/test_obj.py
+++ b/pypy/objspace/std/test/test_obj.py
@@ -252,4 +252,8 @@
     space = objspace.StdObjSpace()
     w_a = space.wrap("a")
     space.type = None
-    space.isinstance_w(w_a, space.w_str) # does not crash
+    # if it crashes, it means that space._type_isinstance didn't go through
+    # the fast path, and tries to call type() (which is set to None just
+    # above)
+    space.isinstance_w(w_a, space.w_unicode) # does not crash
+


More information about the pypy-commit mailing list