[pypy-commit] pypy default: update the comment and kill the XXX, this is not really 'temporary' at all

antocuni noreply at buildbot.pypy.org
Thu Mar 22 11:03:30 CET 2012


Author: Antonio Cuni <anto.cuni at gmail.com>
Branch: 
Changeset: r53889:842c2e057680
Date: 2012-03-22 11:02 +0100
http://bitbucket.org/pypy/pypy/changeset/842c2e057680/

Log:	update the comment and kill the XXX, this is not really 'temporary'
	at all

diff --git a/pypy/module/_socket/test/test_sock_app.py b/pypy/module/_socket/test/test_sock_app.py
--- a/pypy/module/_socket/test/test_sock_app.py
+++ b/pypy/module/_socket/test/test_sock_app.py
@@ -372,10 +372,9 @@
     def test_socket_connect(self):
         import _socket, os
         s = _socket.socket(_socket.AF_INET, _socket.SOCK_STREAM, 0)
-        # XXX temporarily we use python.org to test, will have more robust tests
-        # in the absence of a network connection later when more parts of the
-        # socket API are implemented.  Currently skip the test if there is no
-        # connection.
+        # it would be nice to have a test which works even if there is no
+        # network connection. However, this one is "good enough" for now. Skip
+        # it if there is no connection.
         try:
             s.connect(("www.python.org", 80))
         except _socket.gaierror, ex:


More information about the pypy-commit mailing list