[pypy-commit] pypy default: Merged in jphalip/pypy/popen2-removal (pull request #114)
alex_gaynor
noreply at buildbot.pypy.org
Wed Feb 6 06:22:22 CET 2013
Author: Alex Gaynor <alex.gaynor at gmail.com>
Branch:
Changeset: r60894:1042c2c9707e
Date: 2013-02-05 21:22 -0800
http://bitbucket.org/pypy/pypy/changeset/1042c2c9707e/
Log: Merged in jphalip/pypy/popen2-removal (pull request #114)
Use subprocess instead of the deprecated popen2 inside posix.popen()
diff --git a/pypy/module/posix/app_posix.py b/pypy/module/posix/app_posix.py
--- a/pypy/module/posix/app_posix.py
+++ b/pypy/module/posix/app_posix.py
@@ -140,7 +140,7 @@
Open a pipe to/from a command returning a file object."""
- from popen2 import MAXFD
+ from subprocess import MAXFD
import os, gc
def try_close(fd):
diff --git a/pypy/module/posix/test/test_posix2.py b/pypy/module/posix/test/test_posix2.py
--- a/pypy/module/posix/test/test_posix2.py
+++ b/pypy/module/posix/test/test_posix2.py
@@ -14,7 +14,7 @@
import signal
def setup_module(mod):
- usemodules = ['binascii', 'posix', 'struct', 'rctime']
+ usemodules = ['binascii', 'posix', 'struct', 'rctime', 'signal', 'select']
if os.name != 'nt':
usemodules += ['fcntl']
else:
More information about the pypy-commit
mailing list