[pypy-commit] pypy stmgc-c4: A problem with can_move()

arigo noreply at buildbot.pypy.org
Sat Jul 27 17:09:43 CEST 2013


Author: Armin Rigo <arigo at tunes.org>
Branch: stmgc-c4
Changeset: r65717:8dc08afd119f
Date: 2013-07-27 17:09 +0200
http://bitbucket.org/pypy/pypy/changeset/8dc08afd119f/

Log:	A problem with can_move()

diff --git a/rpython/memory/gc/stmgc.py b/rpython/memory/gc/stmgc.py
--- a/rpython/memory/gc/stmgc.py
+++ b/rpython/memory/gc/stmgc.py
@@ -132,7 +132,8 @@
         seen by the GC, then it can get collected."""
         tid = self.get_hdr_tid(obj)[0]
         if bool(tid & self.GCFLAG_OLD):
-            return False
+            return False    # XXX wrong so far.  We should add a flag to the
+                            # object that means "don't ever kill this copy"
         return True
         
 


More information about the pypy-commit mailing list